Added: manage-contribution-workflow skill; renamed precommit-readiness to prepush-readiness - #360
Open
mridulpathak wants to merge 2 commits into
Open
Conversation
…s to prepush-readiness Adds a manage-contribution-workflow skill covering the OFBiz contribution lifecycle - fork/upstream sync, branching, optional worktree setup, the framework/plugins repo pairing, testing against real data, backporting, and PR conventions - that wasn't covered by the existing domain-pattern skills. Also corrects precommit-readiness, which mischaracterized the repository's git hook as pre-commit when it's actually pre-push (Checkstyle and CodeNarc only); renamed to prepush-readiness with accurate config paths and commands, and cross-referenced it with coding-standards.
… branch/PR
The skill's triggers only fired on starting or creating new work, so resuming a branch/PR from an earlier session could skip loading it entirely; and the upstream-sync step only applied at branch creation, with re-checking before a PR framed as conditional ("if time has passed"). Made both unconditional: added explicit triggers for resuming existing work and for any git push, and require an upstream fetch/drift-check before every push to an existing branch, not just the first one - this gap caused a real PR to land with a conflict.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a manage-contribution-workflow skill covering the OFBiz contribution lifecycle - fork/upstream sync, branching, optional worktree setup, the framework/plugins repo pairing, testing against real data, backporting, and PR conventions - that wasn't covered by the existing domain-pattern skills. Also corrects precommit-readiness, which mischaracterized the repository's git hook as pre-commit when it's actually pre-push (Checkstyle and CodeNarc only); renamed to prepush-readiness with accurate config paths and commands, and cross-referenced it with coding-standards.